X Tutup
Skip to content

Remove PSv2CompletionCompleter#18337

Merged
daxian-dbw merged 11 commits intoPowerShell:masterfrom
xtqqczze:PSv2CompletionCompleter
May 2, 2023
Merged

Remove PSv2CompletionCompleter#18337
daxian-dbw merged 11 commits intoPowerShell:masterfrom
xtqqczze:PSv2CompletionCompleter

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Oct 20, 2022 •
edited
Loading

Contributes to #18323.

Remove references to "PSv2" in: src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs

Breaking changes to public APIs:

@ghost ghost assigned iSazonov Oct 20, 2022
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 20, 2022 •
edited
Loading

3a06f64: LastWordFinder is used for legacy tab expansion (TabExpansion internal function). I will try to remove

PowerShell/src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs

Lines 670 to 673 in 920bf3b

/// LastWordFinder implements the algorithm we use to search for the last word in a line of input taken from the console.
/// This class exists for legacy purposes only - V3 and forward uses a slightly different interface.
/// </summary>
private sealed class LastWordFinder

@xtqqczze xtqqczze force-pushed the PSv2CompletionCompleter branch from 072040d to 0b45fbb Compare October 20, 2022 20:47
@xtqqczze xtqqczze force-pushed the PSv2CompletionCompleter branch from 0b45fbb to e86ca2a Compare October 20, 2022 20:53
@xtqqczze xtqqczze force-pushed the PSv2CompletionCompleter branch from 7038d32 to 06fc7cc Compare October 21, 2022 03:11
@xtqqczze xtqqczze marked this pull request as ready for review October 21, 2022 03:12
iSazonov
iSazonov reviewed Oct 21, 2022
View reviewed changes
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 21, 2022

PowerShell-CI-windows (Test for Windows Windows Test - ElevatedPesterTests - Others) failure:

Set/New/Remove-Service cmdlet tests.Remove-Service can accept a ServiceController as pipeline input

@xtqqczze xtqqczze closed this Oct 21, 2022
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 21, 2022

restarting tests

@xtqqczze xtqqczze reopened this Oct 21, 2022
SteveL-MSFT
SteveL-MSFT requested changes Oct 24, 2022
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some legacy code should be removed

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 24, 2022
@xtqqczze xtqqczze force-pushed the PSv2CompletionCompleter branch from 5996d49 to df593bd Compare October 26, 2022 00:07
@xtqqczze xtqqczze marked this pull request as draft October 26, 2022 00:18
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 26, 2022

Removed "Override TabExpansion with function" and "Override TabExpansion with alias" tests as they relate to the removed code.

@xtqqczze xtqqczze closed this Oct 26, 2022
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 26, 2022

restarting tests

@xtqqczze xtqqczze reopened this Oct 26, 2022
@xtqqczze xtqqczze marked this pull request as ready for review October 26, 2022 01:54
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 26, 2022

@SteveL-MSFT Ready for review, feedback addressed and test failures resolved.

iSazonov
iSazonov reviewed Oct 26, 2022
View reviewed changes
src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs Outdated
*/
}

Copy link
Collaborator

@iSazonov iSazonov Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove.

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 2, 2022
@ghost
Copy link

ghost commented Nov 2, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw daxian-dbw added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 1, 2023
SteveL-MSFT
SteveL-MSFT approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned iSazonov May 2, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label May 2, 2023
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented May 2, 2023

This PR has 391 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +9 -382
Percentile : 79.1%

Total files changed: 2

Change summary by file extension:
.cs : +9 -366
.ps1 : +0 -16

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw merged commit c77c286 into PowerShell:master May 2, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@yan12125 yan12125 mentioned this pull request Nov 25, 2023
Closed
@yan12125 yan12125 mentioned this pull request Dec 6, 2023
Closed
5 tasks
@yan12125 yan12125 mentioned this pull request Jan 5, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@daxian-dbw daxian-dbw

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @SteveL-MSFT @iSazonov @daxian-dbw
X Tutup