Disable strict mode in Get-Error formatting script#10800
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Oct 18, 2019
Merged
Disable strict mode in Get-Error formatting script#10800adityapatwardhan merged 2 commits intoPowerShell:masterfrom
Get-Error formatting script#10800adityapatwardhan merged 2 commits intoPowerShell:masterfrom
Conversation
adityapatwardhan
approved these changes
Oct 17, 2019
adityapatwardhan
approved these changes
Oct 18, 2019
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Need to disable strict mode as the formatting script is dealing with lots of different types of objects dynamically. If user uses
Set-StrictModethen this formatting fails to render anything. Fix is to disable strict mode within the scope of this script. Also rename the label of ErrorIdentifier to ErrorIndex.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.