Stabilize the event handler leaking test and make Start-PSBuild -SMAOnly literally just rebuild S.M.A.dll#10790
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Oct 16, 2019
Merged
Conversation
daxian-dbw
requested review from
TravisEz13,
adityapatwardhan and
anmenaga
as code owners
daxian-dbw
commented
Oct 14, 2019
| } | ||
| finally | ||
| { | ||
| AmsiUtils.Uninitialize(); |
Member
Author
There was a problem hiding this comment.
Note: Uninitialize calls CloseSession internally.
Collaborator
There was a problem hiding this comment.
Please add this explanation and why we combine the tests to the file.
Member
Author
There was a problem hiding this comment.
I don't think the explanation is needed here. It's more confusing as you won't see the original test cases anymore.
Collaborator
|
I believe xUnit runs tests in random order and it looks like the previous implementation depended on some ordering, so this might be the fix |
TravisEz13
approved these changes
Oct 14, 2019
TravisEz13
added
the
CL-Test
TravisEz13
changed the title
Start-PSBuild -SMAOnly literally just rebuild S.M.A.dllStart-PSBuild -SMAOnly literally just rebuild S.M.A.dll
iSazonov
approved these changes
Oct 15, 2019
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
With one minor comment.
Member
Author
|
I will merge this PR to unblock CI failures. |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The event handler test is failing intermittently in our daily test run:
https://powershell.visualstudio.com/PowerShell/_build/results?buildId=35039
The cause of it is likely the
SecuritySupportTests, where the registration/unregistration of the event handler are separately in two tests.I merge those 3 tests into one and will see if that resolves the intermittent failure.
Also slightly update
Start-PSBuildto make-SMAOnlyliterally only re-build and re-deploy S.M.A.dll, without doing extra post-build tasks.The main purpose of this change is to avoid spinning up the
pwshfor retrieving experimental features, so that we can add code in S.M.A.dll to wait for debugger to attach for debugging scenarios. /cc @rjmholtPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.