For ConciseView, show line context information if line is greater than 1 even if there is no scriptname#10746
Merged
iSazonov merged 1 commit intoPowerShell:masterfrom Oct 10, 2019
Conversation
JamesWTruher
approved these changes
Oct 9, 2019
Collaborator
|
Feedback which is not related the PR. Make sense to print error message on new line? Screenshot after I decrease windows width |
iSazonov
approved these changes
Oct 10, 2019
iSazonov
added
the
CL-General
daxian-dbw
approved these changes
Oct 10, 2019
Member
Author
|
@iSazonov can you open a new issue to discuss? Another option is to truncate long lines (not the error message, but the line causing the problem) which NormalView already does today. |
Collaborator
|
Done. |
|
🎉 Handy links: |
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
If you cut and paste a multi-line script into the console (or type it), and there is an error, without this change it just shows the short error message. However, since it's multiple lines, it makes sense to still show the context of the line number. Fix is to allow showing the line context information if the scriptlinenumber is greater than 1 even if there isn't a script file.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.