Make Add-Type usable in application that hosts PowerShell#10587
Merged
adityapatwardhan merged 6 commits intoPowerShell:masterfrom Sep 25, 2019
Merged
Make Add-Type usable in application that hosts PowerShell#10587adityapatwardhan merged 6 commits intoPowerShell:masterfrom
Add-Type usable in application that hosts PowerShell#10587adityapatwardhan merged 6 commits intoPowerShell:masterfrom
Conversation
PoshChan
reviewed
Sep 20, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/AddType.cs
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Sep 21, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/AddType.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Utility/commands/utility/AddType.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
/cc @TylerLeonhardt |
iSazonov
reviewed
Sep 24, 2019
iSazonov
approved these changes
Sep 24, 2019
TylerLeonhardt
approved these changes
Sep 24, 2019
Member
TylerLeonhardt
left a comment
There was a problem hiding this comment.
Such a small change for big impact 😊 LGTM
PaulHigin
approved these changes
Sep 24, 2019
adityapatwardhan
approved these changes
Sep 25, 2019
|
🎉 Handy links: |
|
🎉 Handy links: |
Member
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #9587
Microsoft.PowerShell.SDKship thereffolder, which will be copied to the right place fordotnet buildanddotnet publish.Add-Typeto look for thereffolder at the folder whereEntryAssemblyis located. In case ofpwsh, it's the folder that containspwsh.dll.Add-Typeworks for an application that hosts powershell.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.