$PSCulture follows CurrentThread.CurrentCulture#10138
Merged
iSazonov merged 3 commits intoPowerShell:masterfrom Oct 7, 2019
Merged
$PSCulture follows CurrentThread.CurrentCulture#10138iSazonov merged 3 commits intoPowerShell:masterfrom
iSazonov merged 3 commits intoPowerShell:masterfrom
Conversation
iSazonov
added
Committee-Reviewed
PoshChan
reviewed
Jul 12, 2019
PoshChan
reviewed
Jul 12, 2019
PoshChan
reviewed
Jul 12, 2019
Collaborator
Author
|
@PoshChan Please restart Macos |
Collaborator
Author
|
@PoshChan Please retry Macos |
Collaborator
|
@iSazonov, successfully started retry of |
iSazonov
added
the
Documentation Needed in this repo
TravisEz13
reviewed
Jul 12, 2019
8 tasks
iSazonov
removed
the
Documentation Needed in this repo
Collaborator
Author
|
@SteveL-MSFT @TravisEz13 Since the PR was approved by PowerShell Committee please review the code. |
iSazonov
force-pushed
the
psculture-from-thread
branch
from
597ba0e to
da528d0
Compare
Collaborator
Author
|
Rebased to get latest updates. |
PoshChan
reviewed
Aug 30, 2019
PoshChan
reviewed
Sep 17, 2019
Collaborator
Author
|
@SteveL-MSFT @TravisEz13 Could you please continue the review? |
TravisEz13
approved these changes
Sep 17, 2019
Collaborator
Author
|
@SteveL-MSFT Have you any concerns about the PR? |
Collaborator
Author
|
@SteveL-MSFT Friendly ping. |
|
🎉 Handy links: |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Now $PSCulture gets the value from CurrentThread.CurrentCulture
Close #3831
PowerShell Committee approved the change in #3831
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.