Regenerate the test fixtures with Node 24.3.0#6932
Merged
alcuadrado merged 1 commit intov-nextfrom Jun 26, 2025
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Regenerate the expected output for the nested-test fixture to align with Node v24.3.0’s reverted test_runner behaviors.
- Update test numbering and counts to reflect restored promise handling and cancellation.
- Add newly surfaced stack frames for async subtests in the output.
galargh
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 24.3.0 reverted 3 changes they had introduced in Node 24.0.0, so we need to regenerate a fixture.
These are:
[dce1995c55] - Revert "test_runner: remove promises returned by t.test()" (Romain Menke) #58282
[8b0c5edbb6] - Revert "test_runner: remove promises returned by test()" (Romain Menke) #58282
[6ef7329c8c] - Revert "test_runner: automatically wait for subtests to finish" (Romain Menke) #58282