'bad negation' during config file processing

PatR · PatR · commit 5ac048c8a673 · 2022-11-02T15:56:10.000-07:00
This fixes the problem with reporting "the &lt;foo&gt; option may not
both have a value and be negated" to stdout if delivered before the
interface has been set up, so possibly not be seen.  It has been
using pline_The() but that uses rawprint() during startup.

Unfortunately testing it has uncovered another config file error
reporting issue and this one won't be so easy to fix.  For a logical
line that uses backslash+newline continuations to span multiple
physical lines, when there is a problem it reports the line number
and text of the last segment rather than of the first or of the
specific segment containing the problem.  That isn't necessarily
wrong but is suboptimal.
diff --git a/src/options.c b/src/options.c
@@ -5812,8 +5812,8 @@ string_for_env_opt(const char *optname, char *opts, boolean val_optional)
 static void
 bad_negation(const char *optname, boolean with_parameter)
 {
-    pline_The("%s option may not %sbe negated.", optname,
-              with_parameter ? "both have a value and " : "");
+    config_error_add("The %s option may not %sbe negated.", optname,
+                     with_parameter ? "both have a value and " : "");
 }
 
 /* go through all of the options and set the minmatch value

Original file line number	Diff line number	Diff line change
`@@ -5812,8 +5812,8 @@ string_for_env_opt(const char optname, char opts, boolean val_optional)`
`5812`	`5812`	`static void`
`5813`	`5813`	`bad_negation(const char *optname, boolean with_parameter)`
`5814`	`5814`	`{`
`5815`		`- pline_The("%s option may not %sbe negated.", optname,`
`5816`		`- with_parameter ? "both have a value and " : "");`
	`5815`	`+ config_error_add("The %s option may not %sbe negated.", optname,`
	`5816`	`+ with_parameter ? "both have a value and " : "");`
`5817`	`5817`	`}`
`5818`	`5818`
`5819`	`5819`	`/* go through all of the options and set the minmatch value`