-
Notifications
You must be signed in to change notification settings - Fork 57
Open
Description
As of #278 Stop() simply kills the entire channel, this however should be up to __GC() to do.
the BASS instance can be destroyed but shouldn't affect the lua instance, since this behavior makes playing streams more complicated. (As you'd need to check for IsValid more often and then re-create the instance after each Stop() call)
If you use Pause() on a stream it'll just de-sync and will be behind for as long as it's paused, this is undesired behavior most of the time.
Solutions:
- Handle Stop() differently, keeping the lua instance until actually destroyed trough __GC(), so that Play recreates the BASS instance and plays again... (recommended)
- Make Pause() watch out for streams and give a hint to Play() to re-fetch the stream before playing again (as optional arument to keep both worlds happy)
- Restore Stop()'s old behavior and add a Kill() / Destroy() function to take over the new behavior (not recommended as this messes with people expecting above behavior from Stop() by now)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels