Update return type of Exception::getErrors() to its correct structure#2271
Merged
bshaffer merged 2 commits intogoogleapis:mainfrom Jun 7, 2022
mrtus:patch-1
Merged
Update return type of Exception::getErrors() to its correct structure#2271bshaffer merged 2 commits intogoogleapis:mainfrom mrtus:patch-1
Exception::getErrors() to its correct structure#2271bshaffer merged 2 commits intogoogleapis:mainfrom
mrtus:patch-1
Conversation
The returned errors are an array with a map of keys and values.
```
[
{
"domain": "global",
"reason": "authError",
"message": "Invalid Credentials",
"locationType": "header",
"location": "Authorization"
}
]
```
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
Hi @bshaffer, What is necessary to get this change through? Am I missing some steps that would complete this change request for it to be verified & merged? |
bshaffer
approved these changes
Jun 7, 2022
|
Hi, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the latest update static analysis tools hinted on this wrongly typed structure.
The returned structure of
Exception::getErrors()is an array with a map of keys and values.The change was introduced here #2252