X Tutup
Skip to content

feat: add docs generation action and fix docs#1872

Merged
bshaffer merged 3 commits intomasterfrom
add-docs-generation-action
Jul 10, 2020
Merged

feat: add docs generation action and fix docs#1872
bshaffer merged 3 commits intomasterfrom
add-docs-generation-action

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jul 9, 2020

Documentation generation for google-api-php-client

Example: http://bshaffer.github.io/google-api-php-client/master/

@googlebot
Copy link

googlebot commented Jul 9, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 9, 2020
bshaffer
bshaffer commented Jul 9, 2020
View reviewed changes
.github/workflows/docs.yml
with:
timeout_minutes: 10
max_attempts: 3
command: composer config repositories.sami vcs https://${{ secrets.GITHUB_TOKEN }}@github.com/jdpedrie/sami.git && composer require sami/sami:dev-master && git reset --hard HEAD
Copy link
Contributor Author

@bshaffer bshaffer Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to use a tag once we have one!

@bshaffer bshaffer force-pushed the add-docs-generation-action branch from 9a84c6d to 625f927 Compare July 9, 2020 22:06
@googlebot
Copy link

googlebot commented Jul 9, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 9, 2020
@bshaffer bshaffer force-pushed the add-docs-generation-action branch from 625f927 to 1005e16 Compare July 9, 2020 22:06
@bshaffer bshaffer merged commit 8e92159 into master Jul 10, 2020
@bshaffer bshaffer deleted the add-docs-generation-action branch July 10, 2020 16:32
@davidbrnovjak davidbrnovjak mentioned this pull request Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dwsupplee dwsupplee dwsupplee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bshaffer @googlebot @dwsupplee
X Tutup