X Tutup
Skip to content

chore: automate asset release#1852

Merged
jdpedrie merged 2 commits intogoogleapis:masterfrom
jdpedrie:chore/automate-asset-release
Jun 18, 2020
Merged

chore: automate asset release#1852
jdpedrie merged 2 commits intogoogleapis:masterfrom
jdpedrie:chore/automate-asset-release

Conversation

@jdpedrie
Copy link
Contributor

This adds a Github action to automatically generate and upload release assets when a new release is created.

This has a couple advantages over the manual process:

  • It runs natively on multiple versions of PHP, so we don't need --prefer-lowest.
  • We can generate releases for more versions of PHP. I'm running it here for 5.4, 5.6, 7.0 and 7.4.
  • It's automatic

Sample Run
Sample Release

@jdpedrie jdpedrie requested a review from bshaffer June 18, 2020 14:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2020
@jdpedrie jdpedrie force-pushed the chore/automate-asset-release branch from 970dc1e to 2bf32ed Compare June 18, 2020 14:06
@jdpedrie jdpedrie force-pushed the chore/automate-asset-release branch from 2bf32ed to 8b594ea Compare June 18, 2020 14:07
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just one suggestion

@jdpedrie jdpedrie merged commit c7f965f into googleapis:master Jun 18, 2020
@jdpedrie jdpedrie deleted the chore/automate-asset-release branch June 18, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup